BE User's Weekly Dashboard #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted model associations by using dbdiagram.io. route created for dashboard
…d JSON attributes
…onse for the dashboard
…user-dashboard latest main to branch for latest testing and dashboard work
…ing the serialized dashboard json response i want. refactored controllers to allow me to actually get my dashboard the info it needs.
…DashboardSerializer
…rce. All policies testing green
…, which I dont understand
|
Great work on what you did with the auth and dashboard! The way you've handled job app and contact scopes is spot on. Great way to make sure data is only seen by who owns it! |
CCirbo
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This branch introduces the Dashboard for a user to track their Job apps, Companies, and Contacts. I have not included the logic to filter it by 'weekly' as stated in the comp. Maybe a future issue?
Motivation and Context
A user dashboard is important for this website so that a user can keep tally of what they have done to earn employment via Tracker. It basically serializes a users info and that users CompanySerializer, JobApplicationSerializer and ContactsSerializer. The FE needs this BE to be done so they can start using real data.
I went and combined issue #42 and issue #43 because they needed to be done for me to proceed. Also tested.
Related Tickets
closes #42
closes #11
closes #43
Screenshots (if appropriate):
Added Test?
/api/v1/users/create_spec. They are all broken and I dunno how to fix. Here it is:Checklist:
Questions
I'm wondering if the users table and the contacts table will have any issues in the future is a user is ALSO another users contact? Both tables attributes are incongruent w/ each other. Probably not.
I did not create a dashboard class since, at this point, I felt I did not need it. Should I create an issue to create if for future scalability as well as filtering resources so that they expire after a week? See comp of issue #11
Any ideas for DashboardController edge cases I can throw in the mix for the future?